From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbeDSHqv (ORCPT ); Thu, 19 Apr 2018 03:46:51 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:34669 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbeDSHqs (ORCPT ); Thu, 19 Apr 2018 03:46:48 -0400 X-Google-Smtp-Source: AIpwx49EvqLQMXHSM8jzb3yfdUhC71yIoYLkZChaqp4dwYJpxaZ+tCi0EeES8LqT3iit2yeab35NWQ== Date: Thu, 19 Apr 2018 09:46:45 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kai-Heng Feng Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, andy@infradead.org, mario.limonciello@dell.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Message-ID: <20180419074645.p47cevwpzwwak3sk@pali> References: <20180419072449.4514-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180419072449.4514-1-kai.heng.feng@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 19 April 2018 15:24:49 Kai-Heng Feng wrote: > There are two new events generated by dell-wmi, rfkill and fn-lock, from > Dell Systems. > > These events are for notification purpose, so we can ignore them. > > Tested on XPS 9370. > > Signed-off-by: Kai-Heng Feng > --- > I ordered them functionally instead of alphabetically, I can re-order > them to alphabetically if that's more diserable. Please order them by event code like they were prior your change. > drivers/platform/x86/dell-wmi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 8d102195a392..51d2845d2ad9 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -266,6 +266,13 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = { > > /* Fn-lock */ > { KE_IGNORE, 0x151, { KEY_RESERVED } }, > + { KE_IGNORE, 0xe035, { KEY_RESERVED } }, > + > + /* Fn-lock switched to function keys */ > + { KE_IGNORE, 0x0000, { KEY_RESERVED } }, > + > + /* Fn-lock switched to multimedia keys */ > + { KE_IGNORE, 0x0001, { KEY_RESERVED } }, Are you sure that all those codes are not defined in 0xB2 DMI hotkey table? Also is Fn-lock key reported by PS/2 AT Keyboard controller so it is needed to ignored it by WMI? > /* Change keyboard illumination */ > { KE_IGNORE, 0x152, { KEY_KBDILLUMTOGGLE } }, > @@ -275,6 +282,7 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = { > * WMI event is supposed to trigger an action). > */ > { KE_IGNORE, 0x153, { KEY_RFKILL } }, > + { KE_IGNORE, 0xe008, { KEY_RFKILL } }, > > /* RGB keyboard backlight control */ > { KE_IGNORE, 0x154, { KEY_RESERVED } }, -- Pali Rohár pali.rohar@gmail.com