From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Tobias Regnery <tobias.regnery@gmail.com>
Cc: joro@8bytes.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: fix unused-variable warning
Date: Fri, 20 Apr 2018 11:47:14 +0200 [thread overview]
Message-ID: <20180420094714.kjir26edq34i6ktq@linutronix.de> (raw)
In-Reply-To: <20180420092836.12219-1-tobias.regnery@gmail.com>
On 2018-04-20 11:28:36 [+0200], Tobias Regnery wrote:
> The iommu_table_lock is only used by code inside an ifdef CONFIG_IRQ_REMAP
> block. This leads to the following warning with CONFIG_IRQ_REMAP=n:
>
> amd_iommu.c:86:24: warning: 'iommu_table_lock' defined but not used [-Wunused-variable]
>
> Guard the spinlock definition with the same ifdef.
>
> Fixes: ea6166f4b83e9 ("iommu/amd: Split irq_lookup_table out of the amd_iommu_devtable_lock")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Thank you for spotting this, I am waiting for Jörg to pick up this
instead:
http://lkml.kernel.org/r/20180404105713.633983-1-arnd@arndb.de
Sebastian
prev parent reply other threads:[~2018-04-20 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 9:28 Tobias Regnery
2018-04-20 9:47 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420094714.kjir26edq34i6ktq@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias.regnery@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®