From: Peter Zijlstra <peterz@infradead.org>
To: Kan Liang <kan.liang@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org, eranian@google.com, osk@google.com,
mark@voidzero.net, ak@linux.intel.com
Subject: Re: [RESEND PATCH 2/2] perf/x86/intel/uncore: Fix SBOX support for Broadwell CPUs
Date: Fri, 20 Apr 2018 12:29:46 +0200 [thread overview]
Message-ID: <20180420102946.GI4064@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1521810690-2576-2-git-send-email-kan.liang@linux.intel.com>
On Fri, Mar 23, 2018 at 09:11:30AM -0400, Kan Liang wrote:
> @@ -3067,7 +3069,15 @@ void bdx_uncore_cpu_init(void)
> /* BDX-DE doesn't have SBOX */
> if (boot_cpu_data.x86_model == 86)
> uncore_msr_uncores[BDX_MSR_UNCORE_SBOX] = NULL;
> -
> + /* Detect systems with no SBOXes */
That really wants { }.
> + else if (uncore_extra_pci_dev[pkg].dev[HSWEP_PCI_PCU_3]) {
> + u32 capid4;
> + pci_read_config_dword(
> + uncore_extra_pci_dev[pkg].dev[HSWEP_PCI_PCU_3],
> + 0x94, &capid4);
> + if (((capid4 >> 6) & 0x3) == 0)
> + bdx_msr_uncores[BDX_MSR_UNCORE_SBOX] = NULL;
> + }
> hswep_uncore_pcu.constraints = bdx_uncore_pcu_constraints;
> }
Otherwise these look fine to me;
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Thomas will you magic them into tip?
next prev parent reply other threads:[~2018-04-20 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 13:11 [RESEND PATCH 1/2] perf/x86/intel/uncore: Revert "Remove SBOX support for Broadwell server" Kan Liang
2018-03-23 13:11 ` [RESEND PATCH 2/2] perf/x86/intel/uncore: Fix SBOX support for Broadwell CPUs Kan Liang
2018-04-19 19:10 ` Stephane Eranian
2018-04-20 10:29 ` Peter Zijlstra [this message]
2018-04-20 10:43 ` [tip:perf/urgent] " tip-bot for Oskar Senft
2018-04-20 11:22 ` tip-bot for Oskar Senft
2018-04-20 10:43 ` [tip:perf/urgent] perf/x86/intel/uncore: Revert "Remove SBOX support for Broadwell server" tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420102946.GI4064@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@voidzero.net \
--cc=mingo@redhat.com \
--cc=osk@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome