From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbeDTRiM (ORCPT ); Fri, 20 Apr 2018 13:38:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:39464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbeDTRiL (ORCPT ); Fri, 20 Apr 2018 13:38:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77C5820C09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Fri, 20 Apr 2018 12:38:09 -0500 From: Bjorn Helgaas To: Jakub Kicinski Cc: oss-drivers@netronome.com, Tal Gilboa , Tariq Toukan , Jacob Keller , Ganesh Goudar , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: Add PCIe to pcie_print_link_status() messages Message-ID: <20180420173809.GR28657@bhelgaas-glaptop.roam.corp.google.com> References: <20180413181638.6424-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180413181638.6424-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 11:16:38AM -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today users may get confused into thinking > that it's the NIC bandwidth that is being talked about. Insert a > "PCIe" into the messages. > > Signed-off-by: Jakub Kicinski Applied to for-linus for v4.17, thanks! > --- > drivers/pci/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index aa86e904f93c..73a0a4993f6a 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -5273,11 +5273,11 @@ void pcie_print_link_status(struct pci_dev *dev) > bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); > > if (bw_avail >= bw_cap) > - pci_info(dev, "%u.%03u Gb/s available bandwidth (%s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", > bw_cap / 1000, bw_cap % 1000, > PCIE_SPEED2STR(speed_cap), width_cap); > else > - pci_info(dev, "%u.%03u Gb/s available bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > bw_avail / 1000, bw_avail % 1000, > PCIE_SPEED2STR(speed), width, > limiting_dev ? pci_name(limiting_dev) : "", > -- > 2.16.2 >