From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755278AbeDWN0y (ORCPT ); Mon, 23 Apr 2018 09:26:54 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:35182 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbeDWN0v (ORCPT ); Mon, 23 Apr 2018 09:26:51 -0400 Date: Mon, 23 Apr 2018 16:26:13 +0300 From: Dan Carpenter To: Mark Rutland Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , "Gustavo A. R. Silva" Subject: Re: Smatch check for Spectre stuff Message-ID: <20180423132613.6bjmwtlnvmm4iu7l@mwanda> References: <20180419051510.GA21898@mwanda> <20180420124750.fgwrsyhuqd26mj34@lakrids.cambridge.arm.com> <20180423125307.fpqn5shjq3rpsyx3@mwanda> <20180423132242.iwpltjacdk3xyktf@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180423132242.iwpltjacdk3xyktf@lakrids.cambridge.arm.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8871 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804230138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 23, 2018 at 02:22:43PM +0100, Mark Rutland wrote: > On Mon, Apr 23, 2018 at 03:53:07PM +0300, Dan Carpenter wrote: > > On Fri, Apr 20, 2018 at 01:47:51PM +0100, Mark Rutland wrote: > > > > What the test does is it looks at array accesses where the user controls > > > > the offset. It asks "is this a read?" and have we used the > > > > array_index_nospec() macro? If the answers are yes, and no respectively > > > > then print a warning. > > > > > > > > http://repo.or.cz/smatch.git/blob/HEAD:/check_spectre.c > > > > > > I just built this and threw it at v4.17-rc1, but I'm having problems > > > with the build_kernel_data.sh step. > > > > > > I get an error: > > > > > > DBD::SQLite::db do failed: unrecognized token: "'end + strlen(" > > > " at ../smatch/smatch_scripts/../smatch_data/db/fill_db_sql.pl line 32, line 294127. > > > > > > ... in my smatch_warns.txt I see that I have the lines: > > > > > > net/netfilter/nf_conntrack_sip.c:1524 sip_help_tcp() SQL: insert or ignore into constraints (str) values('end + strlen("^M > > > ^M > > > ")'); > > > > > > ... and the corresponding line in that file is: > > > > > > for (; end + strlen("\r\n\r\n") <= dptr + datalen; end++) { > > > > > > ... so I guess there's some dodgy escaping somewhere? > > > > > > I only see a small number of potential spectre issues reported: > > > > Yeah... Sorry. I will fix that. It doesn't affect anything unless > > someone starts to add SQL injection strings to the kernel but it's not > > the right thing. > > Good to know! As long as that's not affecting the results, I'll ignore > that for now. > > As an aside, it looks like smatch_data/db/constraints_required.schema is > missing a trailing semicolon, as the other schema files have. On one of > my machines, the distro's sqlite doesn't seem happy without it. > Oops! I'll fix that. regards, dan carpenter