From: Peter Zijlstra <peterz@infradead.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
diego.viola@gmail.com, len.brown@intel.com, rjw@rjwysocki.net,
rui.zhang@intel.com
Subject: [PATCH 3/5] clocksource: Initialize cs->wd_list
Date: Mon, 23 Apr 2018 18:16:51 +0200 [thread overview]
Message-ID: <20180423162642.113827596@infradead.org> (raw)
In-Reply-To: <20180423161648.622657048@infradead.org>
[-- Attachment #1: peterz-tsc-early-fix-3.patch --]
[-- Type: text/plain, Size: 774 bytes --]
In a number of places we rely on list_empty(&cs->wd_list), however we
do not initialize this list_head. Do so upon registration, such that
thereafter we can rely on list_empty() correctly reflecting the list
membership status.
Tested-by: Diego Viola <diego.viola@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/time/clocksource.c | 2 ++
1 file changed, 2 insertions(+)
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -332,6 +332,8 @@ static void clocksource_resume_watchdog(
static void clocksource_enqueue_watchdog(struct clocksource *cs)
{
+ INIT_LIST_HEAD(&cs->wd_list);
+
if (cs->flags & CLOCK_SOURCE_MUST_VERIFY) {
/* cs is a clocksource to be watched. */
list_add(&cs->wd_list, &watchdog_list);
next prev parent reply other threads:[~2018-04-23 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 16:16 [PATCH 0/5] Various tsc/clocksource fixes Peter Zijlstra
2018-04-23 16:16 ` [PATCH 1/5] x86,tsc: Always unregister clocksource_tsc_early Peter Zijlstra
2018-04-23 16:16 ` [PATCH 2/5] clocksource: Allow clocksource_mark_unstable() on unregisered clocksources Peter Zijlstra
2018-04-23 16:41 ` Peter Zijlstra
2018-04-23 16:43 ` Peter Zijlstra
2018-04-23 16:16 ` Peter Zijlstra [this message]
2018-04-23 16:16 ` [PATCH 4/5] x86,tsc: Fix mark_tsc_unstable() Peter Zijlstra
2018-04-23 16:16 ` [PATCH 5/5] clocksource: Consistent de-rate when marking unstable Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423162642.113827596@infradead.org \
--to=peterz@infradead.org \
--cc=diego.viola@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®