From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756508AbeDXHox (ORCPT ); Tue, 24 Apr 2018 03:44:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:51480 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920AbeDXHor (ORCPT ); Tue, 24 Apr 2018 03:44:47 -0400 From: Jiri Slaby To: rjw@rjwysocki.net Cc: linux-kernel@vger.kernel.org, Jiri Slaby , Martin Kelly , Len Brown , Robert Moore , Erik Schmauss , linux-acpi@vger.kernel.org, devel@acpica.org Subject: [PATCH 1/1] tools: power/acpi, revert to LD = gcc Date: Tue, 24 Apr 2018 09:43:44 +0200 Message-Id: <20180424074344.23029-1-jslaby@suse.cz> X-Mailer: git-send-email 2.16.3 In-Reply-To: <54661ff7-5c2a-473b-e08c-1cd267353c03@martingkelly.com> References: <54661ff7-5c2a-473b-e08c-1cd267353c03@martingkelly.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica (acpidump) in power/acpi: ld: unrecognized option '-D_LINUX' The tools pass CFLAGS to the linker (incl. -D_LINUX), so revert this particular change and let LD be $(CC) again. Note that the old behaviour was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by the commit 7ed1c1901fe5. We use $(CC) for that reason. Signed-off-by: Jiri Slaby Cc: Martin Kelly Cc: "Rafael J. Wysocki" Cc: Len Brown Cc: Robert Moore Cc: Erik Schmauss Cc: linux-acpi@vger.kernel.org Cc: devel@acpica.org --- tools/power/acpi/Makefile.config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config index 2cccbba64418..f304be71c278 100644 --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -56,6 +56,7 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} # to compile vs uClibc, that can be done here as well. CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- CROSS_COMPILE ?= $(CROSS) +LD = $(CC) HOSTCC = gcc # check if compiler option is supported -- 2.16.3