From: Steven Rostedt <rostedt@goodmis.org>
To: Wei Wang <wvw@google.com>
Cc: gregkh@linuxfoundation.org, Wei Wang <wei.vince.wang@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Crt Mori <cmo@melexis.com>,
Alexei Starovoitov <ast@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] do not call trace_printk on non-debug build
Date: Tue, 24 Apr 2018 15:26:07 -0400 [thread overview]
Message-ID: <20180424152607.71fbee34@gandalf.local.home> (raw)
In-Reply-To: <CAGXk5yriz2CtCN-vkL0q7gdpV+f8+9GJH-FT+v3KBLb-fWoCZA@mail.gmail.com>
On Tue, 24 Apr 2018 19:20:03 +0000
Wei Wang <wvw@google.com> wrote:
> checkpatch.pl sounds good. One thing to add is we have many off tree
> patches with abuse trace_printk. Also as you mentioned, given this is
> really not for use in production and we have been cleaning this our on our
> side for years, could we consider to enforce this in kernel?
That nasty warning was suppose to be the enforcement. I would expect
nobody would ship a kernel where it produced such a message on boot (or
loading of a module). If they don't notice, then they are not testing
their code.
A lot of kernel developers use trace_printk() and I want to make it as
easy to use as possible. I don't want to add a config to enable it,
because that would be something that could be rather annoying.
Let's add it to checkpatch and see if that can draining the swamp of
abusers.
-- Steve
next prev parent reply other threads:[~2018-04-24 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 18:08 Wei Wang
2018-04-24 18:50 ` Steven Rostedt
2018-04-24 19:02 ` Wei Wang
2018-04-24 19:14 ` Steven Rostedt
2018-04-24 19:20 ` Wei Wang
2018-04-24 19:26 ` Steven Rostedt [this message]
2018-04-24 20:39 ` Wei Wang
2018-04-24 20:45 ` Steven Rostedt
2018-04-24 20:48 ` Steven Rostedt
2018-04-24 21:32 ` Wei Wang
2018-04-25 0:49 ` Randy Dunlap
2018-04-25 4:53 ` Wei Wang
2018-04-27 1:46 ` Steven Rostedt
2018-04-25 6:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424152607.71fbee34@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cmo@melexis.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=wei.vince.wang@gmail.com \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®