mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: andy.gross@linaro.org, broonie@kernel.org,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	gregkh@linuxfoundation.org, david.brown@linaro.org,
	mark.rutland@arm.com, lgirdwood@gmail.com, plai@codeaurora.org,
	bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, rohkumar@qti.qualcomm.com,
	spatakok@qti.qualcomm.com
Subject: Re: [PATCH v5 04/23] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings
Date: Tue, 24 Apr 2018 11:14:04 -0500	[thread overview]
Message-ID: <20180424161404.v3ecysrg7z4v3ejp@rob-hp-laptop> (raw)
In-Reply-To: <20180418153157.1960-5-srinivas.kandagatla@linaro.org>

On Wed, Apr 18, 2018 at 04:31:38PM +0100, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patch add DT bindings for AFE (Audio Frontend) DSP module.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Reviewed-and-tested-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
>  .../devicetree/bindings/sound/qcom,q6afe.txt       | 88 ++++++++++++++++++++++
>  include/dt-bindings/sound/qcom,q6afe.h             | 31 ++++++++
>  2 files changed, 119 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.txt
>  create mode 100644 include/dt-bindings/sound/qcom,q6afe.h
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
> new file mode 100644
> index 000000000000..3925726a3319
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
> @@ -0,0 +1,88 @@
> +Qualcomm Audio Front End (Q6AFE) binding
> +
> +AFE is one of the APR audio service on Q6DSP
> +Please refer to qcom,apr.txt for details of the common apr service bindings
> +used by all apr services.
> +
> +- but must contain the following property:
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "qcom,afe-v<MAJOR-NUMBER>.<MINOR-NUMBER>"
> +		  Or "qcom,afe" where the version number can be queried
> +		  from DSP.
> +		  example "qcom,afe-v2.0"

Doesn't match the APR example.

> +
> += AFE DAIs (Digial Audio Interface)
> +"dais" subnode of the AFE node represents dai specific configuration
> +
> +- #sound-dai-cells
> +	Usage: required
> +	Value type: <prop-encoded-array>

array?

> +	Definition: Must be 1
> +
> +- reg
> +	Usage: required
> +	Value type: <prop-encoded-array>

array or single value?

> +	Definition: Must be dai id
> +
> +- qcom,sd-lines
> +	Usage: required for mi2s interface
> +	Value type: <prop-encoded-array>
> +	Definition: Must be list of serial data lines used by this dai.
> +	should be one or more of the 1-4 sd lines.
> +
> += EXAMPLE
> +
> +q6afe {
> +	compatible = "qcom,q6afe";
> +	reg = <APR_SVC_AFE>;
> +
> +	dais {
> +		#sound-dai-cells = <1>;
> +		hdmi@1 {
> +			reg = <1>;
> +		};
> +
> +		prim-mi2s-rx@16 {
> +			reg = <16>;
> +			qcom,sd-lines = <1 3>;
> +		};
> +
> +		prim-mi2s-tx@17 {
> +			reg = <17>;
> +			qcom,sd-lines = <2>;
> +		};
> +
> +		sec-mi2s-rx@18 {
> +			reg = <18>;
> +			qcom,sd-lines = <1 4>;
> +		};
> +
> +		sec-mi2s-tx@19 {
> +			reg = <19>;
> +			qcom,sd-lines = <2>;
> +		};
> +
> +		tert-mi2s-rx@20 {
> +			reg = <20>;
> +			qcom,sd-lines = <2 4>;
> +		};
> +
> +		tert-mi2s-tx@21 {
> +			reg = <21>;
> +			qcom,sd-lines = <1>;
> +		};
> +
> +		quat-mi2s-rx@22 {
> +			reg = <22>;
> +			qcom,sd-lines = <1>;
> +		};
> +
> +		quat-mi2s-tx@23 {
> +			reg = <23>;
> +			qcom,sd-lines = <2>;
> +		};
> +	};
> +};
> diff --git a/include/dt-bindings/sound/qcom,q6afe.h b/include/dt-bindings/sound/qcom,q6afe.h
> new file mode 100644
> index 000000000000..3c7868394889
> --- /dev/null
> +++ b/include/dt-bindings/sound/qcom,q6afe.h
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#ifndef __DT_BINDINGS_Q6_AFE_H__
> +#define __DT_BINDINGS_Q6_AFE_H__
> +
> +/* Audio Front End (AFE) virtual ports IDs */
> +#define HDMI_RX		1
> +#define SLIMBUS_0_RX    2
> +#define SLIMBUS_0_TX    3
> +#define SLIMBUS_1_RX    4
> +#define SLIMBUS_1_TX    5
> +#define SLIMBUS_2_RX    6
> +#define SLIMBUS_2_TX    7
> +#define SLIMBUS_3_RX    8
> +#define SLIMBUS_3_TX    9
> +#define SLIMBUS_4_RX    10
> +#define SLIMBUS_4_TX    11
> +#define SLIMBUS_5_RX    12
> +#define SLIMBUS_5_TX    13
> +#define SLIMBUS_6_RX    14
> +#define SLIMBUS_6_TX    15
> +#define PRIMARY_MI2S_RX		16
> +#define PRIMARY_MI2S_TX		17
> +#define SECONDARY_MI2S_RX	18
> +#define SECONDARY_MI2S_TX	19
> +#define TERTIARY_MI2S_RX	20
> +#define TERTIARY_MI2S_TX	21
> +#define QUATERNARY_MI2S_RX	22
> +#define QUATERNARY_MI2S_TX	23
> +
> +#endif /* __DT_BINDINGS_Q6_AFE_H__ */
> +
> -- 
> 2.16.2
> 

  reply	other threads:[~2018-04-24 16:14 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 15:31 [PATCH v5 00/23] ASoC: qcom: Add support to QDSP based Audio srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 01/23] soc: qcom dt-bindings: Add APR bus bindings srinivas.kandagatla
2018-04-24 15:52   ` Rob Herring
2018-04-24 15:57     ` Mark Brown
2018-04-24 15:59       ` Srinivas Kandagatla
2018-04-24 16:04     ` Srinivas Kandagatla
2018-04-18 15:31 ` [PATCH v5 02/23] soc: qcom: Add APR bus driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 03/23] ASoC: qdsp6: q6common: Add qdsp6 helper functions srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 04/23] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings srinivas.kandagatla
2018-04-24 16:14   ` Rob Herring [this message]
2018-04-18 15:31 ` [PATCH v5 05/23] ASoC: qdsp6: dt-bindings: Add q6adm " srinivas.kandagatla
2018-04-24 16:15   ` Rob Herring
2018-04-18 15:31 ` [PATCH v5 06/23] ASoC: qdsp6: dt-bindings: Add q6asm " srinivas.kandagatla
2018-04-24 16:17   ` Rob Herring
2018-04-24 16:20     ` Srinivas Kandagatla
2018-04-18 15:31 ` [PATCH v5 07/23] ASoC: qdsp6: q6afe: Add q6afe driver srinivas.kandagatla
2018-04-20  0:50   ` [alsa-devel] " kbuild test robot
2018-04-18 15:31 ` [PATCH v5 08/23] ASoC: qdsp6: qdafe: Add SLIMBus port Support srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 09/23] ASoC: qdsp6: q6afe: Add support to MI2S ports srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 10/23] ASoC: qdsp6: q6afe: Add support to MI2S sysclks srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 11/23] ASoC: qdsp6: q6adm: Add q6adm driver srinivas.kandagatla
2018-04-20  1:44   ` kbuild test robot
2018-04-18 15:31 ` [PATCH v5 12/23] ASoC: qdsp6: q6asm: Add q6asm driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 13/23] ASoC: qdsp6: q6asm: Add support to memory map and unmap srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 14/23] ASoC: qdsp6: q6asm: Add support to audio stream apis srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 15/23] ASoC: qdsp6: q6core: Add q6core driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 16/23] ASoC: qdsp6: q6routing: Add q6routing driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 17/23] ASoC: qdsp6: q6routing: Add support to all SLIMBus Mixers srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 18/23] ASoC: qdsp6: q6routing: Add support to MI2S Mixers srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 19/23] ASoC: qdsp6: q6afe: Add q6afe dai driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 20/23] ASoC: qdsp6: q6asm: Add q6asm " srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings srinivas.kandagatla
2018-04-24 16:25   ` Rob Herring
2018-04-24 16:49     ` Srinivas Kandagatla
2018-04-25 15:04       ` Rob Herring
2018-04-25 16:16         ` Srinivas Kandagatla
2018-04-25 16:21         ` Mark Brown
2018-04-18 15:31 ` [PATCH v5 22/23] ASoC: qcom: apq8096: Add db820c machine driver srinivas.kandagatla
2018-04-18 15:31 ` [PATCH v5 23/23] MAINTAINERS: Add myself as co-maintainer of qcom audio srinivas.kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424161404.v3ecysrg7z4v3ejp@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.gross@linaro.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=rohkumar@qti.qualcomm.com \
    --cc=spatakok@qti.qualcomm.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®