From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: allen.lkml@gmail.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: amd8111e: remove redundant duplicated if statement
Date: Wed, 25 Apr 2018 14:12:37 -0400 (EDT) [thread overview]
Message-ID: <20180425.141237.1661627015961946958.davem@davemloft.net> (raw)
In-Reply-To: <20180425103113.8013-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 25 Apr 2018 11:31:13 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two identical nested if statements, the second is redundant
> and can be removed. Also clean up white space formatting.
>
> Cleans up cppcheck warning:
> drivers/net/ethernet/amd/amd8111e.c:1080: (warning) Identical inner 'if'
> condition is always true.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2018-04-25 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 10:31 Colin King
2018-04-25 18:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425.141237.1661627015961946958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allen.lkml@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®