From: Mark Brown <broonie@kernel.org>
To: David Collins <collinsd@codeaurora.org>
Cc: Doug Anderson <dianders@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver
Date: Wed, 25 Apr 2018 11:31:36 +0100 [thread overview]
Message-ID: <20180425103136.GB24769@sirena.org.uk> (raw)
In-Reply-To: <20a8f736-2687-f14f-eaa1-2b2c06eed629@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Tue, Apr 24, 2018 at 02:09:47PM -0700, David Collins wrote:
> On 04/24/2018 10:45 AM, Mark Brown wrote:
> > I think that's probably only OK if we have a specific error code for the
> > regulator being limited in this way otherwise our error handling for I/O
> > problems involves us trying to reconfigure supplies which seems like it
> > would be risky.
> Would you be ok with -EAGAIN being used for this purpose?
Using -EAGAIN for "I can't ever read the configuration from this
regulator" doesn't seem right - it's not like any number of retries
will ever manage to read the value back.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-04-25 10:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 2:50 [PATCH v2 0/2] " David Collins
2018-04-14 2:50 ` [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings David Collins
2018-04-16 20:57 ` Rob Herring
2018-04-16 22:06 ` David Collins
2018-04-17 20:06 ` Doug Anderson
2018-04-18 21:44 ` David Collins
2018-05-02 16:37 ` Doug Anderson
2018-05-03 0:13 ` David Collins
2018-05-03 15:01 ` Doug Anderson
2018-04-14 2:50 ` [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver David Collins
2018-04-17 18:23 ` [v2,2/2] " Matthias Kaehlcke
2018-04-17 19:15 ` David Collins
2018-04-17 19:47 ` Matthias Kaehlcke
2018-04-18 21:34 ` David Collins
2018-04-18 17:02 ` Mark Brown
2018-04-17 20:02 ` [PATCH v2 2/2] " Doug Anderson
2018-04-18 23:30 ` David Collins
2018-04-19 6:04 ` Stephen Boyd
2018-04-19 16:16 ` Doug Anderson
2018-04-20 22:08 ` David Collins
2018-04-24 17:45 ` Mark Brown
2018-04-24 21:09 ` David Collins
2018-04-25 10:31 ` Mark Brown [this message]
2018-04-25 21:04 ` David Collins
2018-05-01 21:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425103136.GB24769@sirena.org.uk \
--to=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®