From: Stefan Potyra <Stefan.Potyra@elektrobit.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>,
"sil2review@lists.osadl.org" <sil2review@lists.osadl.org>
Subject: Re: [PATCH] Enable clock before calling clk_get_rate() on it.
Date: Wed, 2 May 2018 10:34:26 +0200 [thread overview]
Message-ID: <20180502083420.GA8549@er01809n.ebgroup.elektrobit.com> (raw)
In-Reply-To: <4863111525100577@web2o.yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
Hi Evgeniy,
On Mon, Apr 30, 2018 at 06:02:57PM +0300, Evgeniy Polyakov wrote:
> Hi Stefan
>
> Nice catch, thank you!
>
> 19.04.2018, 16:02, "Stefan Potyra" <stefan.potyra@elektrobit.com>:
> > According to the API, you may only call clk_get_rate() after actually
> > enabling it.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Fixes: a5fd9139f74c w1: add 1-wire master driver for i.MX27 / i.MX31
> > Signed-off-by: Stefan Potyra <Stefan.Potyra@elektrobit.com>
>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Oops, just saw that now the clock is leaked in the error case of mdev->regs.
I'll respin the patch and fix that.
Cheers,
Stefan.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-02 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 13:02 Stefan Potyra
2018-04-30 15:02 ` Evgeniy Polyakov
2018-05-02 8:34 ` Stefan Potyra [this message]
2018-05-02 8:55 ` [PATCH v2] w1: mxc_w1: " Stefan Potyra
2018-05-08 11:02 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502083420.GA8549@er01809n.ebgroup.elektrobit.com \
--to=stefan.potyra@elektrobit.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sil2review@lists.osadl.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®