mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT
Date: Wed, 2 May 2018 08:50:13 -0400	[thread overview]
Message-ID: <20180502085013.2571183b@gandalf.local.home> (raw)
In-Reply-To: <20180502112948.1747-1-mpe@ellerman.id.au>

On Wed,  2 May 2018 21:29:48 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:

> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
> 
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
> 
> So remove the exception for PPC32 and the comment.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Feel free to take this patch through the PPC tree.

Thanks!

-- Steve

> ---
>  kernel/trace/Kconfig | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c4f0f2e4126e..dd6c0a2ad969 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -110,11 +110,7 @@ config GENERIC_TRACER
>  #
>  config TRACING_SUPPORT
>  	bool
> -	# PPC32 has no irqflags tracing support, but it can use most of the
> -	# tracers anyway, they were tested to build and work. Note that new
> -	# exceptions to this list aren't welcomed, better implement the
> -	# irqflags tracing for your architecture.
> -	depends on TRACE_IRQFLAGS_SUPPORT || PPC32
> +	depends on TRACE_IRQFLAGS_SUPPORT
>  	depends on STACKTRACE_SUPPORT
>  	default y
>  

  reply	other threads:[~2018-05-02 12:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 11:29 Michael Ellerman
2018-05-02 12:50 ` Steven Rostedt [this message]
2018-05-08 14:52 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502085013.2571183b@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®