From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbeECVUj (ORCPT ); Thu, 3 May 2018 17:20:39 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:39961 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbeECVUg (ORCPT ); Thu, 3 May 2018 17:20:36 -0400 Date: Thu, 3 May 2018 14:20:33 -0700 From: Guenter Roeck To: Jerry Hoemann Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] watchdog: hpwdt: Claim NMIs generated by iLO5 Message-ID: <20180503212033.GA32321@roeck-us.net> References: <20180503210055.32483-1-jerry.hoemann@hpe.com> <20180503210055.32483-2-jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180503210055.32483-2-jerry.hoemann@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 03, 2018 at 03:00:55PM -0600, Jerry Hoemann wrote: > On iLO5 going forward we want to return and not claim the NMI, if > the NMI was NOT gnerated by the iLO as a result of the watchdog > timing out or an explicit generate NMI. > > The sense of the test in is inverted and prevents hpwdt_pretimeout > from claiming NMIs when it should. > > Signed-off-by: Jerry Hoemann Fixes: a042229a18ac ("watchdog: hpwdt: Update nmi_panic message.") Reviewed-by: Guenter Roeck > --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index a43ab2cecca2..9dc62a461451 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -159,7 +159,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) > "3. OA Forward Progress Log\n" > "4. iLO Event Log"; > > - if (ilo5 && ulReason == NMI_UNKNOWN && mynmi) > + if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi) > return NMI_DONE; > > if (ilo5 && !pretimeout) > -- > 2.13.6 >