From: Peter Xu <peterx@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Linux IOMMU Mailing List <iommu@lists.linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>,
Jintack Lim <jintack@cs.columbia.edu>,
Alexander Witte <alexander.witte@baicanada.com>
Subject: Re: [PATCH v2 2/3] intel-iommu: generalize __mapping_notify_one()
Date: Fri, 4 May 2018 10:23:52 +0800 [thread overview]
Message-ID: <20180504022352.GK29580@xz-mi> (raw)
In-Reply-To: <20180503131424.jsn4qvfuwur7adcb@8bytes.org>
On Thu, May 03, 2018 at 03:14:24PM +0200, Joerg Roedel wrote:
> On Wed, Apr 18, 2018 at 04:39:52PM +0800, Peter Xu wrote:
> > Generalize this new helper to notify one newly created mapping on one
> > single IOMMU. We can further leverage this helper in the next patch.
>
> You introduce the function, you do not generalize it. Please fix that in
> the subject and description.
>
> Also, please drop patch 1, I don't like this pr_debug stuff in the
> code. And please also fix the subject line in general to match the form:
>
> iommu/vt-d: _I_ntroduce __mapping_notify_one()
>
> When that is done, please re-send.
Will do. Thanks, Joerg.
--
Peter Xu
next prev parent reply other threads:[~2018-05-04 2:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 8:39 [PATCH v2 0/3] intel-iommu: fix mapping PSI missing for iommu_map() Peter Xu
2018-04-18 8:39 ` [PATCH v2 1/3] intel-iommu: add some traces for PSIs Peter Xu
2018-04-18 8:39 ` [PATCH v2 2/3] intel-iommu: generalize __mapping_notify_one() Peter Xu
2018-05-03 13:14 ` Joerg Roedel
2018-05-04 2:23 ` Peter Xu [this message]
2018-04-18 8:39 ` [PATCH v2 3/3] intel-iommu: fix iotlb psi missing for mappings Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504022352.GK29580@xz-mi \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.witte@baicanada.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jintack@cs.columbia.edu \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome