From: Peter Zijlstra <peterz@infradead.org>
To: Rohit Jain <rohit.k.jain@oracle.com>
Cc: matt@codeblueprint.co.uk, mingo@kernel.org,
dhaval.giani@oracle.com, subhra.mazumdar@oracle.com,
steven.sistare@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] sched/core: Don't schedule threads on pre-empted vcpus
Date: Fri, 4 May 2018 11:47:16 +0200 [thread overview]
Message-ID: <20180504094716.GL12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1525294330-7759-1-git-send-email-rohit.k.jain@oracle.com>
On Wed, May 02, 2018 at 01:52:10PM -0700, Rohit Jain wrote:
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 5e10aae..75d1ecf 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4033,6 +4033,9 @@ int idle_cpu(int cpu)
> return 0;
> #endif
>
> + if (vcpu_is_preempted(cpu))
> + return 0;
> +
> return 1;
> }
Basically OK with this, but did you consider idle_cpu() usage outside of
select_idle_sibling()?
For instance, I think got_nohz_idle_kick() isn't quite right with this
on. Similarly for scheduler_tick(), that wants the actual idle state.
next prev parent reply other threads:[~2018-05-04 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 20:52 Rohit Jain
2018-05-04 9:37 ` [tip:sched/core] sched/core: Don't schedule threads on pre-empted vCPUs tip-bot for Rohit Jain
2018-05-04 9:47 ` Peter Zijlstra [this message]
2018-05-04 17:22 ` [RFC] sched/core: Don't schedule threads on pre-empted vcpus Rohit Jain
2018-05-04 17:32 ` Steven Sistare
2018-05-04 17:37 ` Rohit Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504094716.GL12217@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=rohit.k.jain@oracle.com \
--cc=steven.sistare@oracle.com \
--cc=subhra.mazumdar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®