From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbeEDPgp (ORCPT ); Fri, 4 May 2018 11:36:45 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35668 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751272AbeEDPgo (ORCPT ); Fri, 4 May 2018 11:36:44 -0400 Date: Fri, 4 May 2018 12:36:40 -0300 From: Arnaldo Carvalho de Melo To: Alexander Shishkin Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Will Deacon , Adrian Hunter , Markus Metzger Subject: Re: [PATCH v2] perf: Suppress AUX/OVERWRITE records Message-ID: <20180504153640.GC2700@redhat.com> References: <20180403173207.GA8921@arm.com> <20180404145323.28651-1-alexander.shishkin@linux.intel.com> <20180504120959.z6cik4zv6ragblxd@um.fi.intel.com> <20180504153534.GB2700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180504153534.GB2700@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 04, 2018 at 12:35:34PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, May 04, 2018 at 03:09:59PM +0300, Alexander Shishkin escreveu: > > On Wed, Apr 04, 2018 at 05:53:23PM +0300, Alexander Shishkin wrote: > > > It has been pointed out to me many times that it is useful to be able > > > to switch off AUX records to save the bandwidth for records that actually > > > matter, for example, in AUX overwrite mode. > > > > > > The usefulness of PERF_RECORD_AUX is in some of its flags, like the > > > TRUNCATED flag that tells the decoder where exactly gaps in the trace are. > > > The OVERWRITE flag, on the other hand will be set on every single record > > > in overwrite mode. However, a PERF_RECORD_AUX[flags=OVERWRITE] is > > > generated on every target task's sched_out, which over time adds up to > > > a lot of useless information. > > > > > > If any folks out there have userspace that depends on a constant stream of > > > OVERWRITE records for a good reason, they'll have to let us know. > > > > > > Signed-off-by: Alexander Shishkin > > > Cc: Markus Metzger > > > Cc: Adrian Hunter > > > > This one seems to be slipping through the cracks. > > So, did you got Acked-by or tested-by from anyone? Yeah, tons of them, I'll pick this up - Arnaldo