From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbeEDUQQ (ORCPT ); Fri, 4 May 2018 16:16:16 -0400 Received: from mga03.intel.com ([134.134.136.65]:10316 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbeEDUQM (ORCPT ); Fri, 4 May 2018 16:16:12 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,363,1520924400"; d="scan'208";a="225868955" Date: Sat, 5 May 2018 04:16:06 +0800 From: kbuild test robot To: Akshu Agrawal Cc: kbuild-all@01.org, djkurtz@chromium.org, akshu.agrawal@amd.com, Alexander.Deucher@amd.com, "Rafael J. Wysocki" , Len Brown , "open list:ACPI" , open list Subject: [PATCH] ACPI: APD: fix ptr_ret.cocci warnings Message-ID: <20180504201606.GA22737@lkp-wsm-ep1> References: <1525422930-27826-2-git-send-email-akshu.agrawal@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525422930-27826-2-git-send-email-akshu.agrawal@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu drivers/acpi/acpi_apd.c:114:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 451cec30ec2b ("ACPI: APD: Add AMD misc clock handler support") CC: Akshu Agrawal Signed-off-by: Fengguang Wu --- acpi_apd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -111,10 +111,7 @@ static int st_misc_setup(struct apd_priv clkdev = platform_device_register_data(&adev->dev, "clk-st", PLATFORM_DEVID_NONE, clk_data, sizeof(*clk_data)); - if (IS_ERR(clkdev)) - return PTR_ERR(clkdev); - - return 0; + return PTR_ERR_OR_ZERO(clkdev); } static const struct apd_device_desc cz_i2c_desc = {