From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
Aastha Gupta <aastha.gupta4104@gmail.com>,
Roman Storozhenko <romeusmeister@gmail.com>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
Jeff Layton <jlayton@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wenwen Wang <wang6495@umn.edu>, NeilBrown <neilb@suse.com>,
open list <linux-kernel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"moderated list:STAGING - LUSTRE PARALLEL FILESYSTEM"
<lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2] staging: lustre: llite: fix potential missing-check bug when copying lumv
Date: Sat, 5 May 2018 11:29:13 +0300 [thread overview]
Message-ID: <20180505082912.r4a6tawjv7ykedc7@mwanda> (raw)
In-Reply-To: <CAK8Kejq0h_Rgq__W_KSD_u+KUbS=cYkVXoHJpdbDrmYOU+iJDg@mail.gmail.com>
On Fri, May 04, 2018 at 10:01:44AM -0500, Kangjie Lu wrote:
> > There is nothing preventing the user from using struct lov_mds_md_v3 but
> > filling in lmm_magic = LOV_MAGIC_V1 from the beginning, no need for a race.
> >
>
> Right. No need for users to race. There might be a type confusion issue
> though if V1
> object is used as V3 or the other way.
>
It's a bit confusing for someone reading the code, but in terms of the
kernel it's straightforward.
It's like if someone is typing with their toes, that's sort of confusing
but it's not a security issue. And here we're implementing a no typing
with your toes policy just to make things more higienic (static checkers
in this metaphor).
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-05-05 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:01 Kangjie Lu
2018-05-05 8:29 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-30 22:56 Wenwen Wang
2018-05-01 4:06 ` Dilger, Andreas
2018-05-01 8:46 ` Dan Carpenter
2018-05-04 4:19 ` Wenwen Wang
2018-05-04 5:27 ` Dan Carpenter
2018-05-04 5:33 ` Wenwen Wang
2018-05-04 10:08 ` Dilger, Andreas
2018-05-04 14:11 ` Wenwen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180505082912.r4a6tawjv7ykedc7@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aastha.gupta4104@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=neilb@suse.com \
--cc=oleg.drokin@intel.com \
--cc=romeusmeister@gmail.com \
--cc=wang6495@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®