From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932220AbeEHNfD (ORCPT ); Tue, 8 May 2018 09:35:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:57994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932145AbeEHNfC (ORCPT ); Tue, 8 May 2018 09:35:02 -0400 Date: Tue, 8 May 2018 09:34:59 -0400 From: Steven Rostedt To: Thomas Tai Cc: Bjorn Helgaas , bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Gagniuc Subject: Re: [PATCH] PCI/AER: add pcie TLP header information in the tracepoint Message-ID: <20180508093459.092988b6@gandalf.local.home> In-Reply-To: References: <20180402154708.5032-1-thomas.tai@oracle.com> <20180507222136.GD161390@bhelgaas-glaptop.roam.corp.google.com> <20180508090756.57f38d17@gandalf.local.home> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 May 2018 09:25:01 -0400 Thomas Tai wrote: > >>> TP_STRUCT__entry( > >>> __string( dev_name, dev_name ) > >>> __field( u32, status ) > >>> __field( u8, severity ) > >>> + __field( u32, tlp_header_valid) > > > > I'm guessing tlp_header_valid is just a boolean. It's after severity > > which is just one byte long. Why not make this one byte as well, > > otherwise you are wasting 3 bytes. > > Thanks Steven. Yes boolean is fine. But don't use "bool", use u8, as bool can be various sizes on different archs. -- Steve