From: Guenter Roeck <linux@roeck-us.net>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: morbidrsa@gmail.com, wim@linux-watchdog.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: mena21_wdt: Drop unnecessary mutex lock
Date: Tue, 8 May 2018 07:48:22 -0700 [thread overview]
Message-ID: <20180508144822.GA11268@roeck-us.net> (raw)
In-Reply-To: <20180508071206.13375-1-baijiaju1990@gmail.com>
On Tue, May 08, 2018 at 03:12:06PM +0800, Jia-Ju Bai wrote:
> There is already a mutex in the watchdog core which serializes
> calls to the various API functions.
> So the mutex lock "drv->lock" is unnecessary and can be dropped.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mena21_wdt.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/watchdog/mena21_wdt.c b/drivers/watchdog/mena21_wdt.c
> index 25d5d2b8cfbe..0be7f50e8ff9 100644
> --- a/drivers/watchdog/mena21_wdt.c
> +++ b/drivers/watchdog/mena21_wdt.c
> @@ -31,7 +31,6 @@ enum a21_wdt_gpios {
>
> struct a21_wdt_drv {
> struct watchdog_device wdt;
> - struct mutex lock;
> unsigned gpios[NUM_GPIOS];
> };
>
> @@ -55,12 +54,8 @@ static int a21_wdt_start(struct watchdog_device *wdt)
> {
> struct a21_wdt_drv *drv = watchdog_get_drvdata(wdt);
>
> - mutex_lock(&drv->lock);
> -
> gpio_set_value(drv->gpios[GPIO_WD_ENAB], 1);
>
> - mutex_unlock(&drv->lock);
> -
> return 0;
> }
>
> @@ -68,12 +63,8 @@ static int a21_wdt_stop(struct watchdog_device *wdt)
> {
> struct a21_wdt_drv *drv = watchdog_get_drvdata(wdt);
>
> - mutex_lock(&drv->lock);
> -
> gpio_set_value(drv->gpios[GPIO_WD_ENAB], 0);
>
> - mutex_unlock(&drv->lock);
> -
> return 0;
> }
>
> @@ -81,14 +72,10 @@ static int a21_wdt_ping(struct watchdog_device *wdt)
> {
> struct a21_wdt_drv *drv = watchdog_get_drvdata(wdt);
>
> - mutex_lock(&drv->lock);
> -
> gpio_set_value(drv->gpios[GPIO_WD_TRIG], 0);
> ndelay(10);
> gpio_set_value(drv->gpios[GPIO_WD_TRIG], 1);
>
> - mutex_unlock(&drv->lock);
> -
> return 0;
> }
>
> @@ -108,8 +95,6 @@ static int a21_wdt_set_timeout(struct watchdog_device *wdt,
> return -EINVAL;
> }
>
> - mutex_lock(&drv->lock);
> -
> if (timeout == 1)
> gpio_set_value(drv->gpios[GPIO_WD_FAST], 1);
> else
> @@ -117,8 +102,6 @@ static int a21_wdt_set_timeout(struct watchdog_device *wdt,
>
> wdt->timeout = timeout;
>
> - mutex_unlock(&drv->lock);
> -
> return 0;
> }
>
> @@ -191,7 +174,6 @@ static int a21_wdt_probe(struct platform_device *pdev)
> return ret;
> }
>
> - mutex_init(&drv->lock);
> watchdog_init_timeout(&a21_wdt, 30, &pdev->dev);
> watchdog_set_nowayout(&a21_wdt, nowayout);
> watchdog_set_drvdata(&a21_wdt, drv);
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-05-08 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 7:12 Jia-Ju Bai
2018-05-08 8:08 ` Johannes Thumshirn
2018-05-08 14:48 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508144822.GA11268@roeck-us.net \
--to=linux@roeck-us.net \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=morbidrsa@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome