From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933789AbeEIHoC (ORCPT ); Wed, 9 May 2018 03:44:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:57569 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933383AbeEIHoB (ORCPT ); Wed, 9 May 2018 03:44:01 -0400 Date: Wed, 9 May 2018 09:43:57 +0200 From: Michal Hocko To: Mathieu Malaterre Cc: Andrew Morton , Vlastimil Babka , Mel Gorman , Pavel Tatashin , Tetsuo Handa , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move =?utf-8?Q?function_?= =?utf-8?Q?=E2=80=98is=5Fpageblock=5Fremovable=5Fnolock?= =?utf-8?B?4oCZ?= inside blockers Message-ID: <20180509074357.GB32366@dhcp22.suse.cz> References: <20180505201107.21070-1-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180505201107.21070-1-malat@debian.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 05-05-18 22:11:06, Mathieu Malaterre wrote: > Function ‘is_pageblock_removable_nolock’ is not used unless > CONFIG_MEMORY_HOTREMOVE is activated. Move it in between #ifdef sentinel to > match prototype in . Silence gcc warning (W=1): > > mm/page_alloc.c:7704:6: warning: no previous prototype for ‘is_pageblock_removable_nolock’ [-Wmissing-prototypes] Could you move is_pageblock_removable_nolock to mm/memory_hotplug.c and make it static instead? There is only one caller is_mem_section_removable so there shouldn't be any real reason to have it extern and add more ifdefs. > Signed-off-by: Mathieu Malaterre > --- > mm/page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 905db9d7962f..94ca579938e5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7701,6 +7701,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, > return false; > } > > +#ifdef CONFIG_MEMORY_HOTREMOVE > bool is_pageblock_removable_nolock(struct page *page) > { > struct zone *zone; > @@ -7723,6 +7724,7 @@ bool is_pageblock_removable_nolock(struct page *page) > > return !has_unmovable_pages(zone, page, 0, MIGRATE_MOVABLE, true); > } > +#endif > > #if (defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || defined(CONFIG_CMA) > > -- > 2.11.0 > -- Michal Hocko SUSE Labs