mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	"Michal Hocko" <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>, <kernel-team@fb.com>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/cgroup: memory controller self-tests
Date: Thu, 10 May 2018 18:04:16 +0100	[thread overview]
Message-ID: <20180510170410.GA30242@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <72680d54-a0c8-434f-e95c-ab8e4c7c854b@kernel.org>

On Thu, May 10, 2018 at 08:25:06AM -0600, Shuah Khan wrote:
> On 05/09/2018 01:20 PM, Roman Gushchin wrote:
> > Cgroups are used for controlling the physical resource distribution
> > (memory, CPU, io, etc) and often are used as basic building blocks
> > for large distributed computing systems. Even small differences
> > in the actual behavior may lead to significant incidents.
> > 
> > The codebase is under the active development, which will unlikely
> > stop at any time soon. Also it's scattered over different
> > kernel subsystems, which makes regressions more probable.
> > 
> > Given that, the lack of any tests is crying.
> > 
> > This patch implements some basic tests for the memory controller,
> > as well as a minimal required framework.
> > It doesn't pretend for a very good coverage, but pretends
> > to be a starting point.
> > 
> > Hopefully, any following significant changes will
> > include corresponding tests.
> > 
> > Tests for CPU and io controllers, as well as cgroup core
> > are next in the todo list.
> > 
> 
> Thanks you for the patch.

Hi Shuah!

Thank you for taking a look. I've addressed your comments in v2.

Thanks!

      reply	other threads:[~2018-05-10 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 19:20 Roman Gushchin
2018-05-10 14:25 ` Shuah Khan
2018-05-10 17:04   ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510170410.GA30242@castle.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®