From: Olof Johansson <olof@lixom.net>
To: Stefan Agner <stefan@agner.ch>
Cc: arm@kernel.org, arnd@arndb.de, linux@armlinux.org.uk,
ard.biesheuvel@linaro.org, robin.murphy@arm.com,
nicolas.pitre@linaro.org, marc.zyngier@arm.com,
behanw@converseincode.com, keescook@chromium.org,
Bernhard.Rosenkranzer@linaro.org, mka@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] bus: arm-cci: remove unnecessary unreachable()
Date: Mon, 14 May 2018 01:23:03 -0700 [thread overview]
Message-ID: <20180514082303.abk3rnj45i4i2bqn@localhost> (raw)
In-Reply-To: <20180508142726.11646-1-stefan@agner.ch>
On Tue, May 08, 2018 at 04:27:26PM +0200, Stefan Agner wrote:
> Mixing asm and C code is not recommended in a naked function by
> gcc and leads to an error when using clang:
> drivers/bus/arm-cci.c:2107:2: error: non-ASM statement in naked
> function is not supported
> unreachable();
> ^
>
> While the function is marked __naked it actually properly return
> in asm. There is no need for the unreachable() call.
>
> GCC 7.2 generates identical object files before and after, other
> than (for obvious reasons) the line numbers generated by
> WANT_WARN_ON_SLOWPATH for all the WARN()s appearing later in the
> file.
>
> Suggested-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> Acked-by: Nicolas Pitre <nico@linaro.org>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Changes in v3:
> - Fix subject and enhance commit message
> Changes in v2:
> - Don't add assembly ASM_UNREACHABLE, just drop unreachable()
Applied to next/drivers for v4.18 merge window now. Thanks!
-Olof
prev parent reply other threads:[~2018-05-14 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 14:27 Stefan Agner
2018-05-14 8:23 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514082303.abk3rnj45i4i2bqn@localhost \
--to=olof@lixom.net \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mka@chromium.org \
--cc=nicolas.pitre@linaro.org \
--cc=robin.murphy@arm.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®