Re: [RFC PATCH v3 5/5] usb: typec: tcpm: Support for Alternate Modes

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Sun, May 13, 2018 at 12:30:51AM +0300, Andy Shevchenko wrote:
> On Fri, May 11, 2018 at 4:18 PM, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> > This adds more complete handling of VDMs and registration of
> > partner alternate modes, and introduces callbacks for
> > alternate mode operations.
> >
> > Only DFP role is supported for now.
> 
> > +       for (i = 0; i < cnt; i++)
> > +               p[i] = le32_to_cpu(payload[i]);
> 
> I would recommend to consider to use le32_to_cpu_array().
> 
> Though, actually we have slightly different API for BE and LE cases.
> For LE existing would be renamed to rather le32_to_cpus_array() and
> establishing the former one in the similar way how be32_to_cpu_array()
> is implemented.

OK. I'll check it.


Thanks Andy,

-- 
heikki