From: Andrew Morton <akpm@linux-foundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Lihao Liang <lianglihao@huawei.com>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
Pekka Enberg <penberg@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/3] types: use fixed width types without double-underscore prefix
Date: Tue, 15 May 2018 15:59:25 -0700 [thread overview]
Message-ID: <20180515155925.9c16962e2b416e5f507c07b1@linux-foundation.org> (raw)
In-Reply-To: <1526350925-14922-3-git-send-email-yamada.masahiro@socionext.com>
On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> This header file is not exported. It is safe to reference types
> without double-underscore prefix.
>
It may be safe to do this, but why is it desirable?
> index be15897..9834e90 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -10,14 +10,14 @@
> #define DECLARE_BITMAP(name,bits) \
> unsigned long name[BITS_TO_LONGS(bits)]
>
> -typedef __u32 __kernel_dev_t;
> +typedef u32 __kernel_dev_t;
>
> ...
>
next prev parent reply other threads:[~2018-05-15 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 2:22 [PATCH 1/3] int-ll64.h: define u{8,16,32,64} and s{8,16,32,64} based on uapi header Masahiro Yamada
2018-05-15 2:22 ` [PATCH 2/3] types: define aligned_ types " Masahiro Yamada
2018-05-15 2:22 ` [PATCH 3/3] types: use fixed width types without double-underscore prefix Masahiro Yamada
2018-05-15 22:59 ` Andrew Morton [this message]
2018-05-16 1:07 ` Masahiro Yamada
2018-05-16 6:26 ` Greg Kroah-Hartman
2018-05-16 6:59 ` Masahiro Yamada
2018-05-16 7:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515155925.9c16962e2b416e5f507c07b1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=lianglihao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=pombredanne@nexb.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®