From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbeEOR6Y (ORCPT ); Tue, 15 May 2018 13:58:24 -0400 Received: from merlin.infradead.org ([205.233.59.134]:57206 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbeEOR6W (ORCPT ); Tue, 15 May 2018 13:58:22 -0400 Date: Tue, 15 May 2018 19:58:05 +0200 From: Peter Zijlstra To: Waiman Long Cc: Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Davidlohr Bueso , "Theodore Y. Ts'o" , Oleg Nesterov , Amir Goldstein , Jan Kara , Matthew Wilcox Subject: Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN Message-ID: <20180515175805.GN12217@hirez.programming.kicks-ass.net> References: <1526405884-4860-1-git-send-email-longman@redhat.com> <1526405884-4860-3-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526405884-4860-3-git-send-email-longman@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > +/* > + * Owner value to indicate the rwsem's owner is not currently known. > + */ > +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1) It might be nice to comment that this works and relies on having that ANON_OWNER bit set.