Re: [Intel-gfx] [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]

Hi Neil,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc5 next-20180515]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/Add-ChromeOS-EC-CEC-Support/20180516-053811
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   drivers/media/platform/cros-ec-cec/cros-ec-cec.c: In function 'cros_ec_cec_get_notifier':
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.c:232:33: error: 'pci_bus_type' undeclared (first use in this function); did you mean 'pci_pcie_type'?
       d = bus_find_device_by_name(&pci_bus_type, NULL,
                                    ^~~~~~~~~~~~
                                    pci_pcie_type
   drivers/media/platform/cros-ec-cec/cros-ec-cec.c:232:33: note: each undeclared identifier is reported only once for each function it appears in

vim +232 drivers/media/platform/cros-ec-cec/cros-ec-cec.c

   218	
   219	static int cros_ec_cec_get_notifier(struct device *dev,
   220					    struct cec_notifier **notify)
   221	{
   222		int i;
   223	
   224		for (i = 0 ; i < ARRAY_SIZE(cec_dmi_match_table) ; ++i) {
   225			const struct cec_dmi_match *m = &cec_dmi_match_table[i];
   226	
   227			if (dmi_match(DMI_SYS_VENDOR, m->sys_vendor) &&
   228			    dmi_match(DMI_PRODUCT_NAME, m->product_name)) {
   229				struct device *d;
   230	
   231				/* Find the device, bail out if not yet registered */
 > 232				d = bus_find_device_by_name(&pci_bus_type, NULL,
   233							    m->devname);
   234				if (!d)
   235					return -EPROBE_DEFER;
   236	
   237				*notify = cec_notifier_get_conn(d, m->conn);
   238				return 0;
   239			}
   240		}
   241	
   242		/* Hardware support must be added in the cec_dmi_match_table */
   243		dev_warn(dev, "CEC notifier not configured for this hardware\n");
   244	
   245		return -ENODEV;
   246	}
   247	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48217 bytes --]