From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbeEPKnd (ORCPT ); Wed, 16 May 2018 06:43:33 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45920 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbeEPKna (ORCPT ); Wed, 16 May 2018 06:43:30 -0400 Date: Wed, 16 May 2018 12:43:13 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Srinivas Pandruvada , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Len Brown , "Rafael J. Wysocki" , Mel Gorman , the arch/x86 maintainers , Linux PM , Viresh Kumar , Juri Lelli , Linux Kernel Mailing List Subject: Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits Message-ID: <20180516104313.GC12217@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-4-srinivas.pandruvada@linux.intel.com> <20180516072202.GV12217@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 11:15:09AM +0200, Rafael J. Wysocki wrote: > So if the "cached" thing is the last "not boosted EPP", that's why it > is not updated here. Sure, I see what it does, just saying that naming and comments are wrong vs the actual code.