From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbeEPTU5 (ORCPT ); Wed, 16 May 2018 15:20:57 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:39481 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbeEPTUz (ORCPT ); Wed, 16 May 2018 15:20:55 -0400 X-Google-Smtp-Source: AB8JxZoltkpV90q1p8RrjQCl6GvKdR2TGR54Cw/r0jRxhtPH+/GvH2aiFjGM2wylwLndMFXHi2/SPw== From: Mathieu Malaterre To: Linus Walleij Cc: Mathieu Malaterre , Ulf Hansson , Adrian Hunter , Shawn Lin , Wolfram Sang , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl Date: Wed, 16 May 2018 21:20:20 +0200 Message-Id: <20180516192022.23541-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device") a new function `mmc_rpmb_ioctl` was added. The final return is simply returning a value of `0` instead of propagating the correct return code. Discovered during a compilation with W=1, silence the following gcc warning drivers/mmc/core/block.c:2470:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Signed-off-by: Mathieu Malaterre --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 9e923cd1d80e..38a7586b00cc 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2485,7 +2485,7 @@ static long mmc_rpmb_ioctl(struct file *filp, unsigned int cmd, break; } - return 0; + return ret; } #ifdef CONFIG_COMPAT -- 2.11.0