From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
patrick.bellasi@arm.com, viresh.kumar@linaro.org,
tglx@linutronix.de, efault@gmx.de, juri.lelli@redhat.com,
"# v4 . 16+" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] sched/rt: fix call to cpufreq_update_util
Date: Thu, 17 May 2018 11:32:06 +0200 [thread overview]
Message-ID: <20180517093206.GP12235@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180517090530.GO12217@hirez.programming.kicks-ass.net>
On Thu, May 17, 2018 at 11:05:30AM +0200, Peter Zijlstra wrote:
> Hurm.. I think this is also wrong. See how dequeue_rt_stack() is also
> called from the enqueue path. Also, nothing calls cpufreq_update_util()
> on the throttle path now.
>
> And talking about throttle; I think we wanted to check rt_queued in that
> case.
Bah, clearly you also want to update on unthrottle.. but I think there's
more buggered wrt throtteling.
next prev parent reply other threads:[~2018-05-17 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 7:16 Vincent Guittot
2018-05-17 9:05 ` Peter Zijlstra
2018-05-17 9:32 ` Peter Zijlstra [this message]
2018-05-17 20:12 ` Vincent Guittot
2018-06-01 14:37 ` Vincent Guittot
2018-06-26 13:53 ` Vincent Guittot
2018-07-03 7:49 ` [tip:sched/core] sched/rt: Fix call to cpufreq_update_util() tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517093206.GP12235@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@arm.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome