From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbeERGoD (ORCPT ); Fri, 18 May 2018 02:44:03 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42694 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbeERGoC (ORCPT ); Fri, 18 May 2018 02:44:02 -0400 Date: Thu, 17 May 2018 23:44:00 -0700 From: Christoph Hellwig To: Long Li Cc: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [RFC PATCH 00/09] Implement direct user I/O interfaces for RDMA Message-ID: <20180518064400.GB9425@infradead.org> References: <20180518002214.5657-1-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 06:03:09AM +0000, Long Li wrote: > I also want to point out that, I choose to implement .read_iter and .write_iter from file_operations to implement direct I/O (CIFS is already doing this for O_DIRECT, so following this code path will avoid a big mess up). The ideal choice is to implement .direct_IO from address_space_operations that I think eventually we want to move to. No, the direct_IO address space operation is the mess. We're moving away from it.