From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Joey Pabalinas <joeypabalinas@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation
Date: Thu, 17 May 2018 23:31:31 -1000 [thread overview]
Message-ID: <20180518093131.7g5m4mu3mtrgb7so@gmail.com> (raw)
In-Reply-To: <CAK7LNAQaR6bLCL8cu4qbqB=oonr7kD_8XuLdG_ntRr_W_rfKUg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Fri, May 18, 2018 at 04:08:44PM +0900, Masahiro Yamada wrote:
> I do not like hard-coding the file(s) in arch/.
>
> Don't you have an idea to list only directories?
> 'find -type d' or 'ls -F' or something?
How do you feel about the following?
> # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH
> if [ "${ALLSOURCE_ARCHS}" = "" ]; then
> ALLSOURCE_ARCHS="${SRCARCH}"
> elif [ "${ALLSOURCE_ARCHS}" = "all" ]; then
> ALLSOURCE_ARCHS="$(cd "${tree}arch/" && find . -maxdepth 1 -type d | paste -sd' ')"
> ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS//[.\/]}"
> fi
If something like that if acceptable, I'll use that for the v4.
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-18 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 6:25 Joey Pabalinas
2018-05-18 7:08 ` Masahiro Yamada
2018-05-18 9:31 ` Joey Pabalinas [this message]
2018-05-18 9:52 ` Masahiro Yamada
2018-05-18 9:58 ` Joey Pabalinas
2018-05-18 11:03 ` Masahiro Yamada
2018-05-18 11:52 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518093131.7g5m4mu3mtrgb7so@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®