From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
yuyang.du@intel.com, pjt@google.com, bsegall@google.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v3] sched/fair: update scale invariance of PELT
Date: Fri, 18 May 2018 11:17:38 +0100 [thread overview]
Message-ID: <20180518101738.GM30654@e110439-lin> (raw)
In-Reply-To: <20180518093638.GL12198@hirez.programming.kicks-ass.net>
On 18-May 11:36, Peter Zijlstra wrote:
>
> Replying to the latest version available; given the current interest I
> figure I'd re-read some of the old threads and look at this stuff again.
>
> On Fri, Apr 28, 2017 at 04:23:55PM +0200, Vincent Guittot wrote:
>
> > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > index 0978fb7..f8dde36 100644
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -313,6 +313,7 @@ struct load_weight {
> > */
> > struct sched_avg {
> > u64 last_update_time;
> > + u64 stolen_idle_time;
> > u64 load_sum;
> > u32 util_sum;
> > u32 period_contrib;
>
> Right, so sadly Patrick stole that space with the util_est bits.
Sorry :(
However, I remember we already talked about the idea to
update load_avg and runnable_load_avg to use u32:
https://marc.info/?l=linux-kernel&m=151334269426419&w=2
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2018-05-18 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 14:23 Vincent Guittot
2018-05-18 9:36 ` Peter Zijlstra
2018-05-18 10:17 ` Patrick Bellasi [this message]
2018-05-18 12:08 ` Peter Zijlstra
2018-05-18 12:19 ` Peter Zijlstra
2018-05-18 15:16 ` Dietmar Eggemann
2018-05-18 15:43 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518101738.GM30654@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®