From: Greg KH <gregkh@linuxfoundation.org>
To: Sabin Mihai Rapan <sabin.rapan@gmail.com>
Cc: jsimmons@infradead.org, andreas.dilger@intel.com,
oleg.drokin@intel.com, lustre-devel@lists.lustre.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: lustre: Fix inclusion of local headers
Date: Sun, 20 May 2018 14:41:58 +0200 [thread overview]
Message-ID: <20180520124158.GC10031@kroah.com> (raw)
In-Reply-To: <20180516182636.5137-1-sabin.rapan@gmail.com>
On Wed, May 16, 2018 at 08:26:36PM +0200, Sabin Mihai Rapan wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR:UAPI_INCLUDE: No #include in ...include/uapi/... should use a uapi/ path
> prefix
>
> Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
> ---
> drivers/staging/lustre/include/uapi/linux/lnet/lnet-dlc.h | 4 ++--
> drivers/staging/lustre/include/uapi/linux/lnet/lnetctl.h | 2 +-
> drivers/staging/lustre/include/uapi/linux/lnet/nidstr.h | 2 +-
> drivers/staging/lustre/include/uapi/linux/lustre/lustre_cfg.h | 2 +-
> drivers/staging/lustre/include/uapi/linux/lustre/lustre_fid.h | 2 +-
> drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h | 4 ++--
> .../staging/lustre/include/uapi/linux/lustre/lustre_ioctl.h | 2 +-
> .../staging/lustre/include/uapi/linux/lustre/lustre_ostid.h | 2 +-
> .../staging/lustre/include/uapi/linux/lustre/lustre_user.h | 2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/uapi/linux/lnet/lnet-dlc.h b/drivers/staging/lustre/include/uapi/linux/lnet/lnet-dlc.h
> index c1619f411d81..1530ac26b449 100644
> --- a/drivers/staging/lustre/include/uapi/linux/lnet/lnet-dlc.h
> +++ b/drivers/staging/lustre/include/uapi/linux/lnet/lnet-dlc.h
> @@ -29,8 +29,8 @@
> #ifndef LNET_DLC_H
> #define LNET_DLC_H
>
> -#include <uapi/linux/lnet/libcfs_ioctl.h>
> -#include <uapi/linux/lnet/lnet-types.h>
> +#include "libcfs_ioctl.h"
> +#include "lnet-types.h"
Ick, no, please leave as-is, the uapi "rules" are a bit different for
staging drivers.
thanks,
greg k-h
prev parent reply other threads:[~2018-05-20 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 18:26 Sabin Mihai Rapan
2018-05-20 12:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520124158.GC10031@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=jsimmons@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=sabin.rapan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome