From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbeEVAfH (ORCPT ); Mon, 21 May 2018 20:35:07 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:40627 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbeEVAfG (ORCPT ); Mon, 21 May 2018 20:35:06 -0400 X-Google-Smtp-Source: AB8JxZomGrnK/2L9CIO925wijLaiSjPksM+3tmBFF1PcAJ5iP7GuLTEgA9RzXi8A4h2Zslrmtw69Qg== Date: Mon, 21 May 2018 20:35:03 -0400 From: Jon Mason To: Jia-Ju Bai Cc: dave.jiang@intel.com, Allen.Hubbe@emc.com, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue Message-ID: <20180522003503.GA3255@kudzu.us> References: <1523366274-31737-1-git-send-email-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523366274-31737-1-git-send-email-baijiaju1990@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 09:17:54PM +0800, Jia-Ju Bai wrote: > ntb_transport_create_queue() is never called in atomic context. > > ntb_transport_create_queue() is only called by ntb_netdev_probe(), > which is set as ".probe" in struct ntb_transport_client. > > Despite never getting called from atomic context, > ntb_transport_create_queue() calls kzalloc_node() with GFP_ATOMIC, > which does not sleep for allocation. > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, > which can sleep and improve the possibility of sucessful allocation. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it > > Signed-off-by: Jia-Ju Bai Both patches have been applied to my ntb-next branch. Thanks, Jon > --- > drivers/ntb/ntb_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c > index f58d8e3..2c0c8bc 100644 > --- a/drivers/ntb/ntb_transport.c > +++ b/drivers/ntb/ntb_transport.c > @@ -1825,7 +1825,7 @@ struct ntb_transport_qp * > qp->rx_dma_chan ? "DMA" : "CPU"); > > for (i = 0; i < NTB_QP_DEF_NUM_ENTRIES; i++) { > - entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node); > + entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node); > if (!entry) > goto err1; > > @@ -1836,7 +1836,7 @@ struct ntb_transport_qp * > qp->rx_alloc_entry = NTB_QP_DEF_NUM_ENTRIES; > > for (i = 0; i < qp->tx_max_entry; i++) { > - entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node); > + entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node); > if (!entry) > goto err2; > > -- > 1.9.1 >