From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbeEVNkB (ORCPT ); Tue, 22 May 2018 09:40:01 -0400 Received: from muru.com ([72.249.23.125]:43984 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbeEVNj6 (ORCPT ); Tue, 22 May 2018 09:39:58 -0400 Date: Tue, 22 May 2018 06:39:55 -0700 From: Tony Lindgren To: Keerthy Cc: linus.walleij@linaro.org, grygorii.strashko@ti.com, t-kristo@ti.com, Russ.Dill@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org, haojian.zhuang@linaro.org, linux-arm-kernel@lists.infradead.org, d-gerlach@ti.com Subject: Re: [PATCH 12/14] OMAP: CLK: CLKSRC: Add suspend resume hooks Message-ID: <20180522133955.GG98604@atomide.com> References: <1523505239-16229-1-git-send-email-j-keerthy@ti.com> <1523505239-16229-13-git-send-email-j-keerthy@ti.com> <20180412142714.GX5700@atomide.com> <038cc2cd-ff72-c9c9-257b-1c1cc09a66a8@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <038cc2cd-ff72-c9c9-257b-1c1cc09a66a8@ti.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Keerthy [180522 07:59]: > On Thursday 12 April 2018 07:57 PM, Tony Lindgren wrote: > > * Keerthy [180412 03:56]: > >> Add the save and restore for clksrc as part of suspend and resume > >> so that it saves the counter value and restores. This is needed in > >> modes like rtc+ddr in self-refresh not doing this stalls the time. > > > > I suspect this too should really happen with cpu_pm. > > I believe going by the previous set of patches this fits better with > suspend/resume? Yes if you don't need it for cpuidle and other SoC variants don't need it for cpuidle. > > Probably no need to look up the hwmod every time? Especially if am437x > > will start supporting deeper idle modes during runtime. > > Like clockevent i will store the hwmod pointer for clocksource as well. OK Regards, Tony