From: Benson Leung <bleung@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benson Leung <bleung@chromium.org>,
Olof Johansson <olof@lixom.net>,
Gwendal Grignou <gwendal@chromium.org>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Vittorio Gambaletta <linuxbugs@vittgam.net>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: do not try DMI match when ACPI device found
Date: Tue, 22 May 2018 16:48:02 -0700 [thread overview]
Message-ID: <20180522234802.GB229422@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20180522230841.GA22026@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Hi Dmitry,
On Tue, May 22, 2018 at 04:08:41PM -0700, Dmitry Torokhov wrote:
> Older models of Chromebooks did not describe the LPC EC in their ACPI
> tables; starting with Strago-based devices Google is using GOOG0004 device
> to describe EC LPC.
>
> DMI-based match is fragile and does not work reliably, especially when
> using custom firmware. It is also not needed when we can locate the right
> ACPI device, so let's stop bailing out when DMI does not match but the
> right ACPI device is present.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Nice fix. Applied.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-05-22 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 23:08 Dmitry Torokhov
2018-05-22 23:48 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522234802.GB229422@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxbugs@vittgam.net \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®