From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbeEWJk5 (ORCPT ); Wed, 23 May 2018 05:40:57 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:42468 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbeEWJky (ORCPT ); Wed, 23 May 2018 05:40:54 -0400 Date: Wed, 23 May 2018 10:40:33 +0100 From: Russell King - ARM Linux To: Ilia Lin Cc: viresh.kumar@linaro.org, rjw@rjwysocki.net, sudeep.holla@arm.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver Message-ID: <20180523094033.GW17671@n2100.armlinux.org.uk> References: <1526729701-8589-1-git-send-email-ilialin@codeaurora.org> <1527066324-24726-1-git-send-email-ilialin@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527066324-24726-1-git-send-email-ilialin@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 12:05:24PM +0300, Ilia Lin wrote: > + np = dev_pm_opp_of_get_opp_desc_node(cpu_dev); > + if (IS_ERR(np)) > + return PTR_ERR(np); ... > + > + pdev = platform_device_register_simple("cpufreq-dt", -1, NULL, 0); > + if (!IS_ERR(pdev)) Do you need to hold a reference to `np' here? > + return 0; -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up