From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932954AbeEWNKB (ORCPT ); Wed, 23 May 2018 09:10:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59602 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932707AbeEWNKA (ORCPT ); Wed, 23 May 2018 09:10:00 -0400 Date: Wed, 23 May 2018 15:09:50 +0200 From: Peter Zijlstra To: Alexey Budankov Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , linux-kernel , linux-perf-users@vger.kernel.org, Andy Lutomirski Subject: Re: [PATCH v2]: perf/x86: store user space frame-pointer value on a sample Message-ID: <20180523130950.GB12217@hirez.programming.kicks-ass.net> References: <31205dc8-b756-e12b-0249-2ed06c2db9c9@linux.intel.com> <20180509145436.GV12217@hirez.programming.kicks-ass.net> <3ecedd91-1c01-6fc5-4648-89eaf5ff0930@linux.intel.com> <20180510101406.GA12217@hirez.programming.kicks-ass.net> <7051f72e-2570-68c8-1488-33ad1b024031@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7051f72e-2570-68c8-1488-33ad1b024031@linux.intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 01:06:58PM +0300, Alexey Budankov wrote: > Is the patch ready to be up streamed now? Please post a new one where you modify the comment about the syscalls not saving registers and ideally find the commit that made it so. Also; I think Andy would appreciate a comment near the syscall code that refers back to this code and states what registers we rely upon being there (+BP for this patch).