From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbeE1HsZ (ORCPT ); Mon, 28 May 2018 03:48:25 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:44928 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbeE1HsX (ORCPT ); Mon, 28 May 2018 03:48:23 -0400 Date: Mon, 28 May 2018 10:47:56 +0300 From: Dan Carpenter To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] vfio/pci: remove a bogus cast in vfio_msi_set_block() Message-ID: <20180528074756.bgl5fxvn7foe5uhn@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8906 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=870 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805280096 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This cast is confusing... The "start" variable is an unsigned int. We absolutely do not want to cast it to a negative int so why is the cast there? It turns out, when you look at the context, it's a no-op and we can just remove it. Signed-off-by: Dan Carpenter diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index 1c46045b0e7f..2724fed62129 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -368,7 +368,7 @@ static int vfio_msi_set_block(struct vfio_pci_device *vdev, unsigned start, } if (ret) { - for (--j; j >= (int)start; j--) + for (--j; j >= start; j--) vfio_msi_set_vector_signal(vdev, j, -1, msix); }