mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: arm@kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	ionela.voinescu@arm.com,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	chris.redpath@arm.com, linux-renesas-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs
Date: Mon, 28 May 2018 11:23:32 +0200	[thread overview]
Message-ID: <20180528092331.3jon45nsqfdzs5ds@verge.net.au> (raw)
In-Reply-To: <5821a6dbe413b5a217ca1e24ddf8ebfa63ba6ef0.1527244201.git.viresh.kumar@linaro.org>

[Cc Biju Das]

On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote:
> The OPP properties, like "operating-points", should either be present
> for all the CPUs of a cluster or none. If these are present only for a
> subset of CPUs of a cluster then things will start falling apart as soon
> as the CPUs are brought online in a different order. For example, this
> will happen because the operating system looks for such properties in
> the CPU node it is trying to bring up, so that it can create an OPP
> table.
> 
> Add such missing properties.
> 
> Fix other missing property (clock latency) as well to make it all
> work.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Thanks, this looks good to me and it looks like it should have:

Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling")

Biju, as the author of the above patch could you take a look over this fix?

> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 142949d7066f..e4fb31c4f0ee 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -98,8 +98,17 @@
>  			reg = <1>;
>  			clock-frequency = <1500000000>;
>  			clocks = <&cpg CPG_CORE R8A7743_CLK_Z>;
> +			clock-latency = <300000>; /* 300 us */
>  			power-domains = <&sysc R8A7743_PD_CA15_CPU1>;
>  			next-level-cache = <&L2_CA15>;
> +
> +			/* kHz - uV - OPPs unknown yet */
> +			operating-points = <1500000 1000000>,
> +					   <1312500 1000000>,
> +					   <1125000 1000000>,
> +					   < 937500 1000000>,
> +					   < 750000 1000000>,
> +					   < 375000 1000000>;
>  		};
>  
>  		L2_CA15: cache-controller-0 {
> -- 
> 2.15.0.194.g9af6a3dea062
> 

  reply	other threads:[~2018-05-28  9:23 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 10:31 [PATCH 00/15] arm: dts: Fix OPP and cooling device properties Viresh Kumar
2018-05-25 10:31 ` [PATCH 01/15] arm: dts: armada: Fix "#cooling-cells" property's name Viresh Kumar
2018-05-28 14:53   ` Gregory CLEMENT
2018-05-25 10:31 ` [PATCH 02/15] arm: dts: ls1021a: Add missing cooling device properties for CPUs Viresh Kumar
2018-07-03  1:35   ` Shawn Guo
2018-05-25 10:31 ` [PATCH 03/15] arm: dts: mediatek: " Viresh Kumar
2018-06-25 14:58   ` Matthias Brugger
2018-05-25 10:31 ` [PATCH 04/15] arm: dts: rk322x: " Viresh Kumar
2018-06-17 14:47   ` Heiko Stuebner
2018-05-25 10:31 ` [PATCH 05/15] arm: dts: uniphier: " Viresh Kumar
2018-06-01  3:25   ` Masahiro Yamada
2018-05-25 10:31 ` [PATCH 06/15] arm: dts: sun: " Viresh Kumar
2018-05-28  8:44   ` Maxime Ripard
2018-05-28 10:57     ` Viresh Kumar
2018-06-01 15:17       ` Maxime Ripard
2018-06-05  4:47         ` [PATCH V2 1/2] arm: dts: sun8i-h3: " Viresh Kumar
2018-06-05  4:47           ` [PATCH V2 2/2] arm: dts: sunxi: " Viresh Kumar
2018-06-05  7:11             ` Maxime Ripard
2018-06-05 16:02               ` Chen-Yu Tsai
2018-06-06  6:58                 ` Maxime Ripard
2018-05-25 10:31 ` [PATCH 07/15] arm: dts: exynos: " Viresh Kumar
2018-05-29 13:18   ` Krzysztof Kozlowski
2018-05-30  4:38     ` Viresh Kumar
2018-05-30 12:32       ` Krzysztof Kozlowski
2018-05-31  5:22         ` Viresh Kumar
2018-06-20 18:44   ` Krzysztof Kozlowski
2018-05-25 10:31 ` [PATCH 08/15] arm: dts: dra74x: " Viresh Kumar
2018-07-03  6:43   ` Tony Lindgren
2018-05-25 10:31 ` [PATCH 09/15] arm: dts: omap: " Viresh Kumar
2018-07-03  6:44   ` Tony Lindgren
2018-05-25 10:31 ` [PATCH 10/15] arm: dts: rk3288: " Viresh Kumar
2018-06-17 14:47   ` Heiko Stuebner
2018-05-25 10:31 ` [PATCH 11/15] arm: dts: berlin: Add missing OPP " Viresh Kumar
2018-05-25 10:31 ` [PATCH 12/15] arm: dts: highbank: " Viresh Kumar
2018-07-02 20:25   ` Rob Herring
2018-07-02 23:27     ` Olof Johansson
2018-07-03  4:13       ` Viresh Kumar
2018-07-03 14:46         ` Olof Johansson
2018-05-25 10:31 ` [PATCH 13/15] arm: dts: r8a7743: " Viresh Kumar
2018-05-28  9:23   ` Simon Horman [this message]
2018-05-28 10:58     ` Viresh Kumar
2018-05-28 11:58       ` Simon Horman
2018-05-29 13:33         ` Biju Das
2018-05-30  4:47           ` Viresh Kumar
2018-05-30  4:46   ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar
2018-05-31 14:24     ` Simon Horman
2018-06-04  9:57     ` Simon Horman
2018-06-11  9:26     ` Geert Uytterhoeven
2018-05-25 10:32 ` [PATCH 14/15] arm: dts: qcom: " Viresh Kumar
2018-07-18  6:08   ` Viresh Kumar
2018-07-18 10:22   ` Amit Kucheria
2018-07-21 18:56     ` Andy Gross
2018-05-25 10:32 ` [PATCH 15/15] arm: dts: imx: " Viresh Kumar
2018-05-25 11:46   ` Lucas Stach
2018-05-28 11:07     ` Viresh Kumar
2018-07-03  7:12       ` Shawn Guo
2018-07-03  8:56         ` Lucas Stach
2018-07-03 12:34   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528092331.3jon45nsqfdzs5ds@verge.net.au \
    --to=horms@verge.net.au \
    --cc=arm@kernel.org \
    --cc=biju.das@bp.renesas.com \
    --cc=chris.redpath@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®