From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754767AbeE2HFN (ORCPT ); Tue, 29 May 2018 03:05:13 -0400 Received: from verein.lst.de ([213.95.11.211]:53585 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbeE2HFJ (ORCPT ); Tue, 29 May 2018 03:05:09 -0400 Date: Tue, 29 May 2018 09:11:19 +0200 From: Christoph Hellwig To: Finn Thain Cc: Michael Schmitz , Geert Uytterhoeven , Christoph Hellwig , Guenter Roeck , Joshua Thompson , Greg Ungerer , linux-m68k , Linux Kernel Mailing List Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet Message-ID: <20180529071119.GB32615@lst.de> References: <1527378785-13326-1-git-send-email-linux@roeck-us.net> <55c1c33b-4a34-bd72-57de-577ce8d95e0b@gmail.com> <2ffd0de6-e8d6-6449-7c05-cbbfd8a99a97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 03:38:23PM +1000, Finn Thain wrote: > On Tue, 29 May 2018, Michael Schmitz wrote: > > > > > > > Since an arch gets to apply limits in the dma ops it implements, why > > > would arch code also have to set a limit in the form of default > > > platform device masks? Powerpc seems to be the only arch that does > > > this. > > > > One of Christoph's recent patches removed most of arches' dma ops, > > replacing them by one generic implementation instead. m68k was one of > > the affected arches. I concede his patch series is experimental still > > and not in mainline, but may be included at some time. > > I found some patches here, > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-dma-noncoherent.2 > > Looks like m68k_dma_alloc() gets renamed arch_dma_alloc() and the generic > ops don't use the dma masks. This is for the 'coherent' allocations, and literatelly nothing changes for those yet. But for the mapping path this switches m68k to use the dma-direct path, wrapped by dma-noncoherent. And these do check dev->dma_mask, although only really for sanity checking. Btw, can I get a review and testing for the above? They aren't really experimental any more, and I'd like to move architectures over as soon as possible.