mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: Alasdair Kergon <agk@redhat.com>,
	dm-devel@redhat.com, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] dm writecache: fix missing goto in error handling code
Date: Tue, 29 May 2018 14:09:03 -0400	[thread overview]
Message-ID: <20180529180903.GB32763@redhat.com> (raw)
In-Reply-To: <20180527222512.25280-1-colin.king@canonical.com>

On Sun, May 27 2018 at  6:25pm -0400,
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently, the -EFBIG error condition when n_bitmaps_bits is
> too large is falling through to the next statement and the
> error assignment to r is potentially being ignored.  The code
> should be exiting to the error path via label 'bad'. Fix
> this by adding the missing goto statement.
> 
> Detected by CoverityScan, CID#1469377 ("Unused value")
> 
> Fixes: bb15b431d650 ("dm: add writecache target")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, I've picked this up.

      reply	other threads:[~2018-05-29 18:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-27 22:25 Colin King
2018-05-29 18:09 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529180903.GB32763@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=colin.king@canonical.com \
    --cc=dm-devel@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome