From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbeE3KZX (ORCPT ); Wed, 30 May 2018 06:25:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:58932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbeE3KZS (ORCPT ); Wed, 30 May 2018 06:25:18 -0400 Date: Wed, 30 May 2018 15:55:14 +0530 From: Vinod To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Vinod Koul , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy Message-ID: <20180530102514.GD16230@vkoul-mobl> References: <20180526095418.22960-1-robert.jarzmik@free.fr> <20180529072401.GG5666@vkoul-mobl> <874liqtgul.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874liqtgul.fsf@belgarion.home> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-05-18, 21:13, Robert Jarzmik wrote: > Vinod writes: > > > On 26-05-18, 11:54, Robert Jarzmik wrote: > >> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan *dchan) > >> dma_pool_destroy(chan->desc_pool); > >> chan->desc_pool = NULL; > >> > >> + chan->drcmr = (u32)-1; > > > > why not use U32_MAX for this? > But of course, anything else you see ? Nope that was the only one :) -- ~Vinod