From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbeE3QL3 (ORCPT ); Wed, 30 May 2018 12:11:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:35395 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbeE3QL2 (ORCPT ); Wed, 30 May 2018 12:11:28 -0400 Date: Wed, 30 May 2018 18:08:43 +0200 From: David Sterba To: dsterba@suse.cz, Kees Cook , David Sterba , Liu Bo , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: raid56: Remove VLA usage Message-ID: <20180530160843.GG3539@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Kees Cook , David Sterba , Liu Bo , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180529234459.GA15302@beast> <20180530151455.GE3539@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530151455.GE3539@twin.jikos.cz> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 05:14:56PM +0200, David Sterba wrote: > On Tue, May 29, 2018 at 04:44:59PM -0700, Kees Cook wrote: > > In the quest to remove all stack VLA usage from the kernel[1], this > > allocates the working buffers during regular init, instead of using stack > > space. This refactors the allocation code a bit to make it easier > > to review. > > > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com For the record, so this was the last use of VLA in fs/btrfs/ .