mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, Al Stone <ahs3@redhat.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mailbox: PCC: check for negative count for parse failure checking
Date: Wed, 30 May 2018 22:21:19 +0300	[thread overview]
Message-ID: <20180530192119.eexpge4nke4uovlz@mwanda> (raw)
In-Reply-To: <20180530171429.3172-1-colin.king@canonical.com>

On Wed, May 30, 2018 at 06:14:29PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function acpi_table_parse_enties_array can potentially return a
> negative value if parsing fails. Currently the check on the return
> is not checking for errors, so fix this by adding a -ve check too.
> 

The impact is that kmallocs would immediately fail and give you a big
stack trace.

regards,
dan carpenter

      parent reply	other threads:[~2018-05-30 19:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 17:14 Colin King
2018-05-30 17:59 ` Al Stone
2018-05-30 18:24   ` Colin Ian King
2018-05-30 18:49     ` Al Stone
2018-05-30 19:21 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530192119.eexpge4nke4uovlz@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=ahs3@redhat.com \
    --cc=colin.king@canonical.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®