From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: v4l: cadence: add VIDEO_V4L2 dependency
Date: Thu, 31 May 2018 10:07:30 +0200 [thread overview]
Message-ID: <20180531080730.cfkxyt5gwo2lhrgw@flea.home> (raw)
In-Reply-To: <20180530220735.1651221-1-arnd@arndb.de>
On Thu, May 31, 2018 at 12:07:10AM +0200, Arnd Bergmann wrote:
> The cadence media drivers can be built-in while the v4l2 core is a loadable
> module. This is a mistake and leads to link errors:
>
> drivers/media/v4l2-core/v4l2-fwnode.o: In function `v4l2_async_register_subdev_sensor_common':
> v4l2-fwnode.c:(.text+0x12f0): undefined reference to `v4l2_async_subdev_notifier_register'
> v4l2-fwnode.c:(.text+0x1304): undefined reference to `v4l2_async_register_subdev'
> v4l2-fwnode.c:(.text+0x1318): undefined reference to `v4l2_async_notifier_unregister'
> v4l2-fwnode.c:(.text+0x1338): undefined reference to `v4l2_async_notifier_cleanup'
> cdns-csi2rx.c:(.text+0x9f8): undefined reference to `v4l2_subdev_init'
> cdns-csi2rx.c:(.text+0xa78): undefined reference to `v4l2_async_register_subdev'
> drivers/media/platform/cadence/cdns-csi2tx.o: In function `csi2tx_remove':
> cdns-csi2tx.c:(.text+0x88): undefined reference to `v4l2_async_unregister_subdev'
> drivers/media/platform/cadence/cdns-csi2tx.o: In function `csi2tx_probe':
> cdns-csi2tx.c:(.text+0x884): undefined reference to `v4l2_subdev_init'
> cdns-csi2tx.c:(.text+0xa9c): undefined reference to `v4l2_async_register_subdev'
>
> An explicit Kconfig dependency on VIDEO_V4L2 avoids the problem.
>
> Fixes: 1fc3b37f34f6 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-05-31 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 22:07 Arnd Bergmann
2018-05-30 22:07 ` [PATCH 2/2] media: v4l: omap: " Arnd Bergmann
2018-05-31 8:07 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531080730.cfkxyt5gwo2lhrgw@flea.home \
--to=maxime.ripard@bootlin.com \
--cc=arnd@arndb.de \
--cc=bparrot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®