From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbeFAKVb (ORCPT ); Fri, 1 Jun 2018 06:21:31 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48730 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbeFAKVa (ORCPT ); Fri, 1 Jun 2018 06:21:30 -0400 Date: Fri, 1 Jun 2018 11:21:22 +0100 From: Mark Brown To: Thierry Reding Cc: Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org, Andy Shevchenko , Alexander Shiyan , Haojian Zhuang , Aaro Koskinen , Tony Lindgren , Mike Rapoport , Robert Jarzmik , Philipp Zabel , Daniel Mack , Marc Zyngier , Geert Uytterhoeven , Russell King Subject: Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only Message-ID: <20180601102122.GA8677@sirena.org.uk> References: <20180514080640.12515-1-linus.walleij@linaro.org> <20180514080640.12515-2-linus.walleij@linaro.org> <20180601093511.GA11734@ulmo> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <20180601093511.GA11734@ulmo> X-Cookie: OS/2 must die! User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 01, 2018 at 11:35:11AM +0200, Thierry Reding wrote: > > cfg.ena_gpio_invert = !config->enable_high; > Change this line to: > cfg.ena_gpio_invert = false; > fixes the regression and is pretty much the implementation of my above > suggestion to ignore enable-active-high, though we may eventually want > to get rid of ena_gpio_invert altogether, provided that everyone has > moved over to GPIO descriptors. Please send a patch, I can't apply the above :( --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlsRHh8ACgkQJNaLcl1U h9BcIAf/QVTELfKIuHu25/byjgRxQvS63mkX7wuUnOLje4hf+xwXI5rzhjWuMRo3 aEcBDbU580LLBuzBzaP857w0vUy5NvvLlqQFxH/rYQXoDPyH6vjx4TSuSDbyiluq Ql9wp/7MDevHTL8ZR9AyuSu0x3S5z2Gfsc7jaGT8qkEJiYiLG4Lt/DbYqYBl7rAi SMfEelxCNTb37YuEF1O7Pu5jIbqcVmzCNszCdDsqeRxsDStmjeJQYwMJjmhawSal 7FUXl/ntJ1wJFk+EHvp82kfGCLTsOMEs7rEYk1W6JizAAUpLlBDUCKu8HpUx6xOl ++QtllxtiAUz1bgY+If+3KxiFClHrQ== =YYTp -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--