From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752190AbeFAMx4 (ORCPT ); Fri, 1 Jun 2018 08:53:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:52957 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbeFAMxr (ORCPT ); Fri, 1 Jun 2018 08:53:47 -0400 X-Google-Smtp-Source: ADUXVKLTI727WVVVrweHdXKFOiVfHMajKElUYnLqUYARQnzmdwEfqPIQryrnYAZ+LQESuFaCEVhDGw== From: osalvador@techadventures.net To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, pasha.tatashin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH 0/4] Small cleanup for memoryhotplug Date: Fri, 1 Jun 2018 14:53:17 +0200 Message-Id: <20180601125321.30652-1-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oscar Salvador Hi, I wanted to give it a try and do a small cleanup in the memhotplug's code. A lot more could be done, but I wanted to start somewhere. I tried to unify/remove duplicated code. The following is what this patchset does: 1) add_memory_resource() has code to allocate a node in case it was offline. Since try_online_node has some code for that as well, I just made add_memory_resource() to use that so we can remove duplicated code.. This is better explained in patch 1/4. 2) register_mem_sect_under_node() will be called only from link_mem_sections() 3) Get rid of link_mem_sections() in favour of walk_memory_range() with a callback to register_mem_sect_under_node() 4) Drop unnecessary checks from register_mem_sect_under_node() I have done some tests and I could not see anything broken because of this patchset. Oscar Salvador (4): mm/memory_hotplug: Make add_memory_resource use __try_online_node mm/memory_hotplug: Call register_mem_sect_under_node mm/memory_hotplug: Get rid of link_mem_sections mm/memory_hotplug: Drop unnecessary checks from register_mem_sect_under_node drivers/base/memory.c | 2 - drivers/base/node.c | 52 +++++--------------------- include/linux/node.h | 21 +++++------ mm/memory_hotplug.c | 101 ++++++++++++++++++++++++++------------------------ 4 files changed, 71 insertions(+), 105 deletions(-) -- 2.13.6